Add paddlectrl client.
#483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gongweibao
requested review from
Yancey1989,
helinwang,
putcn and
typhoonzero
typhoonzero
reviewed
Nov 9, 2017
| @@ -161,3 +163,8 @@ func (s *TrainingJob) GPU() int { | |||
|
|
|||
| return int(gpu) | |||
| } | |||
|
|
|||
| func (s *TrainingJob) String() string { | |||
There was a problem hiding this comment.
Marshal() 或Serialize()应该更容易理解。
There was a problem hiding this comment.
用String()可以支持这样的使用:
fmt.Fprintf(os.Stderr, "can't create TPR extenion TrainningJob: %s\n", job)
go/paddlectl/submit.go
Outdated
| invalidJobName = "jobname can not contain '.' or '_'" | ||
| ) | ||
|
|
||
| // Config is global config object for paddlecloud commandline |
There was a problem hiding this comment.
paddlecloud => paddlectl
| func putFiles(jobPackage, jobName string) error { | ||
| _, pkgerr := os.Stat(jobPackage) | ||
| if pkgerr == nil { | ||
| // FIXME: upload job package to paddle cloud. |
There was a problem hiding this comment.
可以先去掉注释的代码，只放一个TODO注释。保持develop中代码规范。
| return nil | ||
| } | ||
|
|
||
| func (s *Submitter) getKubeConfig() (string, error) { |
go/paddlectl/kube.go
Outdated
| @@ -0,0 +1,106 @@ | |||
| package paddlectl | |||
There was a problem hiding this comment.
这个文件叫kube.go有点奇怪，可以放到util目录作为一些公用的函数。
typhoonzero
reviewed
Nov 9, 2017
| func putFiles(jobPackage, jobName string) error { | ||
| _, pkgerr := os.Stat(jobPackage) | ||
| if pkgerr == nil { | ||
| // FIXME: upload job package to paddle cloud. |
There was a problem hiding this comment.
可以先去掉注释的代码，只放一个TODO注释。保持develop中代码规范。
go/paddlectl/submit.go
Outdated
| return &paddlejob.TrainerSpec{ | ||
| Entrypoint: p.Entry, | ||
| // FIXME(gongwb): workspace | ||
| //Workspace: p.Workspace, |
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can commit TPR's extension now!.
Fix part of #484