Add parallel executor tests #9950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiayiFeng
changed the title
… add_parallel_executor_tests
chengduoZH
reviewed
Apr 17, 2018
| main = fluid.Program() | ||
| startup = fluid.Program() | ||
| startup.random_seed = 1 # Fix random seed | ||
| with fluid.program_guard(main, startup): | ||
| if seed is not None: | ||
| startup.random_seed = seed | ||
| main.random_seed = seed |
There was a problem hiding this comment.
main.random_seed = seed is unnecessary.
| @@ -123,22 +123,24 @@ def __init__(self, | |||
| allow_op_delay) | |||
| self.scope = scope | |||
|
|
|||
| def run(self, fetch_list, feed_dict={}): | |||
| def run(self, fetch_list, feed={}, feed_dict={}): | |||
There was a problem hiding this comment.
There should have a warning to notify users that feed_dict is deprecated.
chengduoZH
previously approved these changes
Apr 17, 2018
… add_parallel_executor_tests
JiayiFeng
force-pushed
the
add_parallel_executor_tests
branch
from
9449b8d to
e84d3a7
Compare
reyoung
approved these changes
Apr 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.