Matrix API refactor #934
Merged
Matrix API refactor #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hedaoyuan
requested changes
Dec 19, 2016
| virtual void contextProjectionForward(MatrixPtr input, | ||
| MatrixPtr weight, | ||
| virtual void contextProjectionForward(Matrix& input, | ||
| Matrix* weight, |
There was a problem hiding this comment.
Matrix* -> Matrix&
后面的也一样，都用Matrix&就可以了。
There was a problem hiding this comment.
The main motivation to use Matrix * here is that we need to compare "if (weight)" in Matrix.cpp. It might be convenient to use raw pointer here instead of reference. What do you suggest?
added 2 commits
December 19, 2016 17:23
…rixPtr) to reference or raw matrix (Matrix & or Matrix *) contextProjectionForward contextProjectionBackward contextProjectionBackwardData contextProjectionBackwardWeight classificationError The mul functions would be updated later.
tianbingsz
force-pushed
the
paddle_function_mat
branch
from
e00b726
to
4fbf949
Compare
|
Just add the refractor for mul |
tianbingsz
changed the title
hedaoyuan
approved these changes
Dec 20, 2016
wangxicoding
pushed a commit
to wangxicoding/Paddle
that referenced
this pull request
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing parameters, we use object reference or raw pointer instead of shared_ptr. (issue: #703)
The following API has been updated:
contextProjectionForward
contextProjectionBackward
contextProjectionBackwardData
contextProjectionBackwardWeight
classificationError
mul