pserver runs in parallel #9154
Merged
pserver runs in parallel #9154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yancey1989
reviewed
Mar 20, 2018
| // and this will still work. | ||
| std::vector<std::future<void>> fs; | ||
| // block0 contains only listen_and_serv op, start run from block1. | ||
| for (int blkid = 1; blkid < num_blocks - 1; ++blkid) { |
There was a problem hiding this comment.
I noticed that L94 promise num_blocks >= 2, but it looks like that if num_blocks==2, the code would not do anything?
There was a problem hiding this comment.
It's a problem, will fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #9103
Related: #8638
This PR improves send_op performance by 50% using the vgg16 benchmark test (pserver uses 6 cores, more cores can gain better results).