Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix constructor bug in mixed_vector #8364

Merged

Conversation

reyoung
Copy link
Collaborator

@reyoung reyoung commented Feb 11, 2018

Fix #8351
Fix #8342

@CLAassistant
Copy link

CLAassistant commented Feb 11, 2018

CLA assistant check
All committers have signed the CLA.

JiayiFeng
JiayiFeng previously approved these changes Feb 11, 2018
Copy link
Collaborator

@JiayiFeng JiayiFeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -15,6 +15,7 @@

#include "glog/logging.h"
#include "gtest/gtest.h"
#include "mixed_vector.h"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this include needed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

dzhwinter
dzhwinter previously approved these changes Feb 11, 2018
Copy link
Contributor

@dzhwinter dzhwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

kavyasrinet
kavyasrinet previously approved these changes Feb 11, 2018
Copy link

@kavyasrinet kavyasrinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for fixing this.

@reyoung reyoung dismissed stale reviews from kavyasrinet and dzhwinter via 190119b February 11, 2018 03:28
@wangkuiyi wangkuiyi merged commit 9029a9d into PaddlePaddle:develop Feb 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants