-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compile with nccl2 #8196
compile with nccl2 #8196
Conversation
Dockerfile
Outdated
@@ -22,7 +22,7 @@ COPY ./paddle/scripts/docker/root/ /root/ | |||
|
|||
RUN apt-get update && \ | |||
apt-get install -y \ | |||
git python-pip python-dev openssh-server bison libnccl-dev \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should also update tools/manylinux1/Dockerfile.x64
for release builds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libnccl
is not at the nvidia/cuda:8.0-cudnn5-devel-ubuntu16.04
. So I added it back. In this case, we don't need to update tools/manylinux1/Dockerfile.x64
. :)
paddle/platform/CMakeLists.txt
Outdated
@@ -1,5 +1,5 @@ | |||
if(WITH_GPU) | |||
cc_library(enforce SRCS enforce.cc DEPS nccl) | |||
cc_library(enforce SRCS enforce.cc DEPS) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I vaguely remember that NVIDIA guy had upgraded these things with CUDA9, cudnn7, NCCL2.
You teach me that we need to call group_start
before call ALLReduce
NCCL calls. Is it right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for reminding me. I've added group_start
and group_end
in this PR.
Yang Yang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
fix #8195