Adding panic logic and test case #8171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As per my discussion with @wangkuiyi , I will push another commit to instead return a boolean since it will be easier to implement that in Python. |
6 tasks
|
@kavyasrinet This is a redundant PR. There is already a PR for this which I had submitted for review few days back #8132 |
|
Ah I see. Yeah this PR implements similar features along with a test case, we can merge either of them. |
|
@kavyasrinet Okay, I will close #8132. |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a panic case if we are trying to send on a closed channel.
As of now, this PR throws a
runtime_errorif we try to send on a closed channel.Issue: #8172