Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/vector #8045

Merged
merged 2 commits into from
Feb 1, 2018
Merged

Fix/vector #8045

merged 2 commits into from
Feb 1, 2018

Conversation

dzhwinter
Copy link
Contributor

fix #8044

reyoung
reyoung approved these changes Feb 1, 2018
View reviewed changes
Copy link
Collaborator

@reyoung reyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically LGTM

This code should be refactored. ToT

@dzhwinter
Copy link
Contributor Author

Let me refactor it with a full-armed Vector...

@reyoung
Copy link
Collaborator

reyoung commented Feb 1, 2018

Let me refactor it with a full-armed Vector...

Not in hurry. We shall polish our user experience firstly as Yi said.

@dzhwinter dzhwinter merged commit 47ebe43 into PaddlePaddle:develop Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyoung reyoung reyoung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lod Vector lack memory checker before CopyToCUDA
2 participants
@dzhwinter @reyoung