-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make inference_lib_dist for fluid inference shared library #7977
Conversation
luotao1
commented
Jan 30, 2018
•
edited
Loading
edited
- fix compile and install the static library of fluid inference #7827 (comment)
- the shared library now is :
- the command for this fluid inference library is :
- example: https://github.com/luotao1/fluid_inference_example
cmake/external/eigen.cmake
Outdated
set(lib_dir "${CMAKE_INSTALL_PREFIX}/third_party/eigen3") | ||
add_custom_target(eigen3_lib | ||
COMMAND mkdir -p "${lib_dir}/Eigen" "${lib_dir}/unsupported" | ||
COMMAND cp "${EIGEN_INCLUDE_DIR}/Eigen/Core" "${lib_dir}/Eigen" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is better to use ${CMAKE_COMMAND} -E copy_directory
, like here
和@luotao1 线下讨论了一下,我们觉得当前这种修改方式不太美观,且破坏了
|
Discussed with @wangkuiyi
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
可以在copy
函数里面加一些print信息,打印从哪里拷贝到哪里,类似install命令的输出一样。
可以的,再下一个PR中为 |