Make word2vec uses parallel.do when CI #7970
Conversation
reyoung
force-pushed
the
feature/test_w2v_parallel.do
branch
from
0c2657c to
0b4ade1
Compare
* Polish sum_op support SelectedRows in_place
reyoung
force-pushed
the
feature/test_w2v_parallel.do
branch
from
0b4ade1 to
7c0cc11
Compare
reyoung
changed the title
| @@ -68,32 +68,59 @@ class SumKernel : public framework::OpKernel<T> { | |||
| } | |||
| } | |||
| } else if (out_var->IsType<framework::SelectedRows>()) { | |||
| PADDLE_ENFORCE(!in_place, "SelectedRows not support inplace sum now"); | |||
| std::unique_ptr<framework::SelectedRows> in0; | |||
There was a problem hiding this comment.
Make SumOp support SelectedRows in place.
| exit(0) # if avg cost less than 10.0, we think our code is good. | ||
| exit(1) | ||
|
|
||
| def main(use_cuda, is_sparse, parallel): |
There was a problem hiding this comment.
change previous unittest to function main
| for use_cuda in (False, True): | ||
| for is_sparse in (False, True): | ||
| for parallel in (False, True): | ||
| inject_test_method(use_cuda, is_sparse, parallel) |
There was a problem hiding this comment.
inject_test_method to W2VTest
| if use_cuda and is_sparse and parallel: | ||
| fn = __impl__ | ||
| else: | ||
| # skip the other test when on CI server |
There was a problem hiding this comment.
Skip tests if the environment varaible FULL_TEST is not True. It will make our CI faster.
| with fluid.program_guard(prog, startup_prog): | ||
| main(use_cuda=use_cuda, is_sparse=is_sparse, parallel=parallel) | ||
|
|
||
| if use_cuda and is_sparse and parallel: |
There was a problem hiding this comment.
Only test use_cuda=True, is_sparse=True, parallel=True in our CI sever.
|
@QiJune Please review the @tonyyang-svail Please review the unittests. |
|
|
||
| out_value->Resize(framework::make_ddim(in_dim_vec)); | ||
| out_value->Resize(framework::make_ddim(in_dim)); | ||
| out_value->mutable_data<T>(context.GetPlace()); | ||
|
|
||
| math::SelectedRowsAddTo<DeviceContext, T> functor; | ||
|
|
||
| int64_t offset = 0; | ||
| for (int i = 0; i < N; i++) { |
There was a problem hiding this comment.
If in_place=True, the first one should be skipped.
There was a problem hiding this comment.
And the value of offset is also related with the value of in_place
There was a problem hiding this comment.
I get the logic of of in-place support for SelectedRows.
This PR is a sub-job of #7872