Fix the docstring of 'filter groups' in img_conv_layer. #7301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qingqing01
reviewed
Jan 9, 2018
| rest channels will be processed by the rest groups of filters. | ||
| 32 filters to process the input. The input channels will be split into 4 | ||
| pieces. First 256/4 = 64 channels will be processed by first 32/4 = 8 filters. | ||
| The rest channels will be processed by the rest groups of filters. |
There was a problem hiding this comment.
The input channels will be split into 4 pieces. First 256/4 = 64 channels will be processed by first 32/4 = 8 filters. The rest channels will be processed by the rest groups of filters.
这些描述不够准确，可以参考 http://www.paddlepaddle.org/docs/develop/documentation/zh/operators.html#permalink-4-conv2d 文档改下。
peterzhang2029
force-pushed
the
conv_group_fix
branch
2 times, most recently
from
51a19be to
93d94bf
Compare
peterzhang2029
force-pushed
the
conv_group_fix
branch
from
93d94bf to
b3db8ef
Compare
qingqing01
approved these changes
Jan 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #5907 #6173