Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"add data layout" #6955

Merged
merged 7 commits into from
Dec 25, 2017
Merged

"add data layout" #6955

merged 7 commits into from
Dec 25, 2017

Conversation

dzhwinter
Copy link
Contributor

fix #6765

@dzhwinter dzhwinter changed the title "add data layout" "[WIP]add data layout" Dec 25, 2017
@dzhwinter dzhwinter mentioned this pull request Dec 25, 2017
Closed
26 tasks
@dzhwinter dzhwinter changed the title "[WIP]add data layout" "add data layout" Dec 25, 2017
typhoonzero
typhoonzero reviewed Dec 25, 2017
View reviewed changes
paddle/framework/tensor.h
@@ -115,6 +117,10 @@ class Tensor {

inline void check_memory_size() const;

inline DataLayout layout() const { return layout_; }

inline void set_layout(const DataLayout layout) { layout_ = layout; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bind this to pybind?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@typhoonzero
Copy link
Contributor

Seem CI failed on CopyTensor ops, segmentfault

typhoonzero
typhoonzero approved these changes Dec 25, 2017
View reviewed changes
Copy link
Contributor

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

@dzhwinter dzhwinter merged commit 7777c81 into PaddlePaddle:develop Dec 25, 2017
@typhoonzero typhoonzero mentioned this pull request Dec 25, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@typhoonzero typhoonzero typhoonzero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

need to add a data member to represent the Layout of a Tensor
2 participants
@dzhwinter @typhoonzero