add norm op（cross_channel_norm） #6881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
December 22, 2017 15:02
… cross_channel_norm
… cross_channel_norm
… cross_channel_norm
wanghaox
reviewed
Dec 28, 2017
paddle/operators/norm_op.h
Outdated
|
|
||
| template <typename T, int MajorType = Eigen::RowMajor, | ||
| typename IndexType = Eigen::DenseIndex> | ||
| using EigenVector = framework::EigenVector<T, MajorType, IndexType>; |
paddle/operators/norm_op.h
Outdated
| using EigenVector = framework::EigenVector<T, MajorType, IndexType>; | ||
| template <typename T, int MajorType = Eigen::RowMajor, | ||
| typename IndexType = Eigen::DenseIndex> | ||
| using EigenMatrix = framework::EigenMatrix<T, MajorType, IndexType>; |
added 3 commits
January 2, 2018 15:32
… cross_channel_norm
… cross_channel_norm
sweetsky0901
commented
Jan 3, 2018
paddle/operators/norm_op.h
Outdated
| using EigenVector = framework::EigenVector<T, MajorType, IndexType>; | ||
| template <typename T, int MajorType = Eigen::RowMajor, | ||
| typename IndexType = Eigen::DenseIndex> | ||
| using EigenMatrix = framework::EigenMatrix<T, MajorType, IndexType>; |
paddle/operators/norm_op.h
Outdated
|
|
||
| template <typename T, int MajorType = Eigen::RowMajor, | ||
| typename IndexType = Eigen::DenseIndex> | ||
| using EigenVector = framework::EigenVector<T, MajorType, IndexType>; |
emailweixu
reviewed
Jan 6, 2018
| auto scale_eigen = | ||
| framework::EigenVector<T, Eigen::RowMajor, Eigen::DenseIndex>::Flatten( | ||
| *scale); | ||
| for (int n = 0; n < batch_size; ++n) { |
There was a problem hiding this comment.
It seems to me that there is no need to use loop. We can do it for the whole batch together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6561