[eager Tensor] Add __format__ for eager Tensor
#68677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
12 tasks
SigureMo
approved these changes
Oct 14, 2024
| @@ -913,6 +913,12 @@ def __str__(self: Tensor) -> str: | |||
|
|
|||
| return tensor_to_string(self) | |||
|
|
|||
| def __format__(self, format_spec): | |||
There was a problem hiding this comment.
这个下个 PR 加一下类型提示？
这类魔术方法应该不需要加类型提示吧，不是一个公开的能被直接调用的API
| @@ -913,6 +913,12 @@ def __str__(self: Tensor) -> str: | |||
|
|
|||
| return tensor_to_string(self) | |||
|
|
|||
| def __format__(self, format_spec): | |||
| if self.ndim == 0: | |||
| return self.item().__format__(format_spec) | |||
There was a problem hiding this comment.
为什么 0D 的是特殊的呢？
因为只有0D张量才被定义为标量，才能作为一个数被格式化，其它形状目前应该没有支持__format__，来自: https://github.com/pytorch/pytorch/pull/5785/files#diff-3fc4fad2faca4e14e4a1a731cb4a547ce495b67158ca95f8fd3a8d02e9d234b3R303-R306。
| numpy_scalar = paddle_scalar.numpy() | ||
| format_spec = f".{width}f" | ||
| self.assertEqual( | ||
| paddle_scalar.__format__(format_spec), |
There was a problem hiding this comment.
是否可以端到端测试下，比如 "{:.3f}".format(x)，再比如 "{:.{}f}".format(x, 3) 这种复杂 case
目前只测试了 __format__，这容易在端到端验证时（用户的用法）上出问题
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
New features
Description
Pcard-75624
添加动态图Tensor的
__format__功能，支持f"{tensor:.2f}"这类格式化打印方法，省去手动调用Tensor.item()的过程。预期的Tensor为只含有单个元素的0-D Tensor，否则会抛出对应的异常。参考：https://github.com/pytorch/pytorch/blob/main/torch/_tensor.py#L1091-L1096