"remove GPU Sync Interface" #6793
Conversation
| if (range.first == range.second) { | ||
| PADDLE_THROW( | ||
| "'Place' is not supported, Please re-compile with WITH_GPU " | ||
| "option"); |
There was a problem hiding this comment.
"..., Please re-compile with WITH_GPU option"
This hint may not be intuitive. Currently platform::Place contains CUDNNPlace, GPUPlace, CPUPlace, MKLDNNPlace.
I think we can output this unsupported place by calling this.
There was a problem hiding this comment.
You're right.
But we will remove the MKLPlace, CUDNNPlace soon. Place only represent address space, we will split it.
#6746
And, some interface of places isn't supported well. Such as is_cpu_place, default_gpu, we will not fix them because these things will be removed soon.
There was a problem hiding this comment.
People who look at this code may get confused. And you should add a TODO inside the code.
There was a problem hiding this comment.
I am working on removing the Place related problem.
fix #6794