Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【Fix PIR Unittest No.127 BUAA】Fix some test case in PIR #66289

Merged
merged 4 commits into from
Jul 31, 2024
Merged

【Fix PIR Unittest No.127 BUAA】Fix some test case in PIR #66289

merged 4 commits into from
Jul 31, 2024

Conversation

uanu2002
Copy link
Contributor

@uanu2002 uanu2002 commented Jul 19, 2024 •
edited
Loading

PR Category

Others

PR Types

Others

Description

bool类型 只能在动态图使用，非参数不能反向检查。

@paddle-bot paddle-bot bot added the contributor External developers label Jul 19, 2024
@luotao1 luotao1 added the HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务 label Jul 22, 2024
@uanu2002 uanu2002 changed the title Fix PIR Unittest No.127 BUAA】Fix some test case in PIR 【Fix PIR Unittest No.127 BUAA】Fix some test case in PIR Jul 22, 2024
wanghuancoder
wanghuancoder previously approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

luotao1
luotao1 reviewed Jul 24, 2024
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

2024-07-23 18:23:13 ========================================
2024-07-23 18:23:13 The following tests FAILED: 
2024-07-23 18:23:13 	1382 - test_quantile_and_nanquantile (Failed)
2024-07-23 18:23:13             	1472 - test_quantile_and_nanquantile (Failed)

单侧失败

@uanu2002
Copy link
Contributor Author 

2024-07-23 18:23:13 ========================================
2024-07-23 18:23:13 The following tests FAILED: 
2024-07-23 18:23:13 	1382 - test_quantile_and_nanquantile (Failed)
2024-07-23 18:23:13             	1472 - test_quantile_and_nanquantile (Failed)

单侧失败

收到，正在修复～

@uanu2002 uanu2002 mentioned this pull request Jul 26, 2024
Closed
44 tasks
@luotao1 luotao1 merged commit aa31184 into PaddlePaddle:develop Jul 31, 2024
31 checks passed
@uanu2002 uanu2002 deleted the develop5 branch August 1, 2024 12:05
Lans1ot pushed a commit to Lans1ot/Paddle that referenced this pull request Aug 5, 2024
@uanu2002 @Lans1ot
【Fix PIR Unittest No.127 BUAA】Fix some test case in PIR (PaddlePaddle…
2d154fe 
…#66289)

* fix test_quantile_and_nanquantile

* fix test_quantile_and_nanquantile.py

* fix stat

* fix new stat
@uanu2002 uanu2002 mentioned this pull request Aug 9, 2024
Closed
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanghuancoder wanghuancoder wanghuancoder approved these changes

@luotao1 luotao1 Awaiting requested review from luotao1

Assignees

@luotao1 luotao1

@wanghuancoder wanghuancoder

Labels
contributor External developers HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uanu2002 @luotao1 @wanghuancoder