Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Hackathon 6th Fundable Projects 3 No.17】beam_search_decode #65207

Merged
merged 3 commits into from
Jul 2, 2024

Conversation

co63oc
Copy link
Contributor

@co63oc co63oc commented Jun 15, 2024

PR Category

Others

PR Types

Others

Description

17 beam_search_decode

Copy link

paddle-bot bot commented Jun 15, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Jun 15, 2024
@co63oc co63oc force-pushed the fix_beam_search_decode branch 3 times, most recently from fd232bf to 00a3c8c Compare June 24, 2024 04:09
@co63oc co63oc changed the title CI测试不review CI测试不review beam_search_decode Jun 24, 2024
@co63oc co63oc force-pushed the fix_beam_search_decode branch from 3ed50e8 to b6be3c6 Compare June 27, 2024 12:43
@co63oc co63oc force-pushed the fix_beam_search_decode branch from 3c858a9 to 54f13a8 Compare June 28, 2024 08:02
@co63oc co63oc changed the title CI测试不review beam_search_decode 【Hackathon 6th Fundable Projects 3 No.17】beam_search_decode Jun 28, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

funcs目录下的文件名不用加op_def这样的后缀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment on lines 470 to 472
- op : beam_search_decode
args: (Tensor ids, Tensor scores, int beam_size, int end_id)
output: Tensor (sentence_ids), Tensor (sentence_scores)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
  1. 输入tensor是tensor array类型,这应该是个静态图算子
  2. tensor array 在yaml里写成tensor不会有问题吗?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 已修改为静态图
2 配置文件中没有TensorArray类型,是使用Tensor代替TensorArray

@luotao1 luotao1 merged commit 459ef40 into PaddlePaddle:develop Jul 2, 2024
31 of 32 checks passed
@co63oc co63oc deleted the fix_beam_search_decode branch July 2, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants