Auto compare cpu and gpu function. #643

hedaoyuan · 2016-11-28T12:54:09Z

Making it easier to write unittest for comparing gpu and cpu version of a function.
For a detailed description, see issue #385
这个PR部分解决issue #385的问题（详细描述见issue），对test_matrixCompare.cpp里面的test case进行了重构，一部分放到了test_Matrix.cpp里面，一部分放到了test_BaseMatrix.cpp里面，其他的test case另外再起issue和pr解决。

该PR新增一个autotest::AutoCompare，使用AutoCompare对一个成员函数进行CPU/GPU实现的对比，主要步骤如下：

构造一个AutoCompare对象，AutoCompare对象里面会包含一个CpuMatrix和一个GpuMatrix对象；
初始化成员函数所需的参数（只需要初始化CPU部分的参数）
通过cmpWithArg模板函数对成员函数进行CPU和GPU实现的测试。

AutoCompare test(...);
Init Argument arg1,arg2...
test.cmpWithArg(function, arg1, arg2....)

…rix.cpp

…ompare

wangkuiyi

这个PR新增的代码是删掉的代码行数的三倍。它带来了这么好处呢？应该在PR的description里说明。

wangkuiyi · 2016-11-28T21:43:38Z

paddle/math/tests/TensorCheck.h

+#include <gtest/gtest.h>
+#include "paddle/math/Matrix.h"
+
+using namespace paddle;  // NOLINT


如果一定要用using namespace，应该写在 namespace autotest {里面吧？

wangkuiyi · 2016-11-28T21:44:09Z

paddle/math/tests/TensorCheck.h

+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License. */
+


这个 header file 里没有 include guard 也没有 pragma once吗？

wangkuiyi · 2016-11-28T21:49:36Z

paddle/math/tests/TestUtils.h

+#include "paddle/math/Matrix.h"
+#include "TensorCheck.h"
+
+using namespace paddle;  // NOLINT


Google style guide 里建议不用 using namespace是有原因的 https://google.github.io/styleguide/cppguide.html#Namespaces 。这里可以

using paddle::BaseMatrix; using paddle::CpuMatrix; using paddle::GpuMatrix;

Done.
用using可以清楚的知道这个文件里面Test了哪些东西。

hedaoyuan · 2016-11-29T02:31:09Z

这个PR还没写完。另外，test_BaseMatrix.cpp里面的那些test相当于都是新增的，原来并没有覆盖到这些测试。

… test_Matrix.cpp

…est_Matrix.cpp

hedaoyuan · 2016-12-01T13:01:55Z

AutoCompare当前支持Matrix函数的比较，后续会通过别的PR增加对Vector、SparseMatrix等类型的比较。

tianbingsz · 2016-12-05T05:46:16Z

paddle/math/tests/TensorCheck.h

+
+  inline int operator()(real a, real b) {
+    if (std::fabs(a - b) > err_) {
+      if ((std::fabs(a - b) / std::fabs(a)) > (err_ / 10.0f)) {


should we check a != 0 here?

还是需要的，另外提一个issue来fix这个把。

* update_install_doc * follow_comments

* synchronize with develop (PaddlePaddle#642) * update_commitid1.3 (PaddlePaddle#641) * update inference c++ API doc (PaddlePaddle#634) * update inference c++ API doc * fix link * thorough clean for doc (PaddlePaddle#644) * thorough clean * delete_DS_Store * Cherrypick1.3 (PaddlePaddle#652) * thorough clean * delete_DS_Store * [Don't merge now]update_install_doc (PaddlePaddle#643) * update_install_doc * follow_comments * add maxdepth (PaddlePaddle#646) * upload_md (PaddlePaddle#649) * update_version (PaddlePaddle#650) * Translation of 16 new apis (PaddlePaddle#651) * fix_windows * Final update 1.3 (PaddlePaddle#653) * thorough clean * delete_DS_Store * update_1.3 * Deadlink fix (PaddlePaddle#654) * fix_deadlinks * update_docker * Update release_note.rst * Update index_cn.rst * update_Paddle (PaddlePaddle#658) * fix pic (PaddlePaddle#659) * [to 1.3] cn api debug (PaddlePaddle#655) (PaddlePaddle#661) * debug * fix 2 -conv2d * "锚" ==> anchor(s)

* synchronize with develop (PaddlePaddle#642) * update_commitid1.3 (PaddlePaddle#641) * update inference c++ API doc (PaddlePaddle#634) * update inference c++ API doc * fix link * thorough clean for doc (PaddlePaddle#644) * thorough clean * delete_DS_Store * Cherrypick1.3 (PaddlePaddle#652) * thorough clean * delete_DS_Store * [Don't merge now]update_install_doc (PaddlePaddle#643) * update_install_doc * follow_comments * add maxdepth (PaddlePaddle#646) * upload_md (PaddlePaddle#649) * update_version (PaddlePaddle#650) * Translation of 16 new apis (PaddlePaddle#651) * fix_windows * Final update 1.3 (PaddlePaddle#653) * thorough clean * delete_DS_Store * update_1.3 * Deadlink fix (PaddlePaddle#654) * fix_deadlinks * update_docker * Update release_note.rst * Update index_cn.rst * update_Paddle (PaddlePaddle#658) * fix pic (PaddlePaddle#659) * [to 1.3] cn api debug (PaddlePaddle#655) (PaddlePaddle#661) * debug * fix 2 -conv2d * "锚" ==> anchor(s) * Weekly cherrypick0302 (PaddlePaddle#668) * Update programming_guide.md (PaddlePaddle#664) * Update programming_guide.md * Update programming_guide_en.md * Update cn api to 1.3 (PaddlePaddle#663) * Update cn api to 1.3 fluid & layers * Rest to 1.3 * Weeklyupdate 0301 (PaddlePaddle#666) * Tables_rm_op * update_op * update_index * update_book_0302 (PaddlePaddle#667) * fix_format (PaddlePaddle#669) (PaddlePaddle#670) * fix_format * Update Tables.md * Update Tables_en.md * add dataset api_cn (PaddlePaddle#673) * rm fluid.core in desigin_idea (PaddlePaddle#674) * Update fluid_design_idea.md * Update fluid_design_idea_en.md * Fix array_read code example error. (PaddlePaddle#671) Signed-off-by: zhaoyuchen <[email protected]> * add data_reader_cn (PaddlePaddle#676) * fix doc error (PaddlePaddle#675) * update_book_commitid (PaddlePaddle#680) * update_book_commitid * commitid0309 * fix typo * book indexes (PaddlePaddle#677)

* Add QAT in GPT example * Add QAT in GPT example

* add styleclip * update 2022 * add weight url * update doc & img url

hedaoyuan added 5 commits November 28, 2016 19:37

Add a auto compare for BaseMatrix

ff7b428

move some BaseMatrix test from test_matrixCompare.cpp to test_BaseMat…

85e0cd7

…rix.cpp

Merge branch 'develop' of https://github.com/baidu/Paddle into auto_c…

409a8a1

…ompare

modify the file name test_matrix.cpp to test_SparseMatrix.cpp

1bac8e6

Add test_Matrix.cpp for auto compare member functions of class Matrix

1873945

wangkuiyi requested changes Nov 28, 2016

View reviewed changes

hedaoyuan added 3 commits November 29, 2016 16:49

move some test from test_matrixCompare.cpp to test_BaseMatrix.cpp and…

f70fc4a

… test_Matrix.cpp

Add a AutoCompare and move some test form test_matrixCompare.cpp to t…

1df826e

…est_Matrix.cpp

add some comments

c410382

hedaoyuan mentioned this pull request Dec 1, 2016

Making it easier to write unittest for comparing gpu and cpu version of a function #385

Closed

hedaoyuan added 2 commits December 1, 2016 20:19

delete BaseMatrixCompare, and add AutoCompare::cmpWithoutArg

ee52c75

Merge branch 'master' into auto_compare

956b661

hedaoyuan assigned wangkuiyi, emailweixu and tianbingsz Dec 1, 2016

some bug fix

1147990

This was referenced Dec 1, 2016

重构paddle/math/tests/ #695

Closed

重构class Matrix里面的一些计算API #703

Closed

wangkuiyi approved these changes Dec 5, 2016

View reviewed changes

hedaoyuan merged commit 17f7125 into PaddlePaddle:develop Dec 5, 2016

tianbingsz reviewed Dec 5, 2016

View reviewed changes

zhhsplendid pushed a commit to zhhsplendid/Paddle that referenced this pull request Sep 25, 2019

[Don't merge now]update_install_doc (PaddlePaddle#643)

790ea16

* update_install_doc * follow_comments

heavengate pushed a commit to heavengate/Paddle that referenced this pull request Aug 24, 2022

Add QAT in GPT example (PaddlePaddle#643)

7eb25e8

* Add QAT in GPT example * Add QAT in GPT example

AnnaTrainingG pushed a commit to AnnaTrainingG/Paddle that referenced this pull request Sep 19, 2022

add styleclip (PaddlePaddle#643)

d1225d0

* add styleclip * update 2022 * add weight url * update doc & img url

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Auto compare cpu and gpu function. #643

Auto compare cpu and gpu function. #643

hedaoyuan commented Nov 28, 2016 •

edited

Loading

wangkuiyi left a comment

wangkuiyi Nov 28, 2016 •

edited

Loading

hedaoyuan Nov 30, 2016

wangkuiyi Nov 28, 2016

hedaoyuan Nov 30, 2016

wangkuiyi Nov 28, 2016

hedaoyuan Nov 30, 2016

hedaoyuan commented Nov 29, 2016

hedaoyuan commented Dec 1, 2016

tianbingsz Dec 5, 2016

hedaoyuan Dec 5, 2016

Auto compare cpu and gpu function. #643

Auto compare cpu and gpu function. #643

Conversation

hedaoyuan commented Nov 28, 2016 • edited Loading

wangkuiyi left a comment

Choose a reason for hiding this comment

wangkuiyi Nov 28, 2016 • edited Loading

Choose a reason for hiding this comment

hedaoyuan Nov 30, 2016

Choose a reason for hiding this comment

wangkuiyi Nov 28, 2016

Choose a reason for hiding this comment

hedaoyuan Nov 30, 2016

Choose a reason for hiding this comment

wangkuiyi Nov 28, 2016

Choose a reason for hiding this comment

hedaoyuan Nov 30, 2016

Choose a reason for hiding this comment

hedaoyuan commented Nov 29, 2016

hedaoyuan commented Dec 1, 2016

tianbingsz Dec 5, 2016

Choose a reason for hiding this comment

hedaoyuan Dec 5, 2016

Choose a reason for hiding this comment

hedaoyuan commented Nov 28, 2016 •

edited

Loading

wangkuiyi Nov 28, 2016 •

edited

Loading