[PIR] fix property overwrite #60225
Merged
[PIR] fix property overwrite #60225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
kangguangli
commented
Dec 25, 2023
| @@ -96,17 +96,27 @@ function(set_pit_tests_properties) | |||
| PIR_OP_TESTS) | |||
| foreach(IR_OP_TEST ${PIR_OP_TESTS}) | |||
| if(TEST ${IR_OP_TEST}) | |||
| set_tests_properties( | |||
There was a problem hiding this comment.
This will lead to property overwritten by later settings and cause environment variables invaid.
winter-wang
approved these changes
Dec 26, 2023
Wanglongzhi2001
pushed a commit
to Wanglongzhi2001/Paddle
that referenced
this pull request
Jan 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description
How many unit tests in white list is covered?
Currently there is 294 files set with environment variables, but the total num should be
num_white_list+num_relax_list+num_no_check_list, which is 354.How many tests are disabled temporarily in this PR?
Others
Pcard-67164