【PIR API adaptor No.160、204、216 】 Migrate NLLLoss/BCEWithLogitsLoss/MarginRankingLoss into pir #58832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
你的PR提交成功，感谢你对开源项目的贡献! |
21 tasks
This comment was marked as off-topic.
This comment was marked as off-topic.
DrRyanHuang
commented
Nov 25, 2023
Comment on lines
+1271
to
+1273
| if not in_pir_mode(): | ||
| # TODO: Segmentation fault in pir mode | ||
| self.assertRaises(ValueError, test_x_shape_lt_1) |
There was a problem hiding this comment.
PIR模式下会有 Segmentation fault, 所以加了if分支
|
麻烦在pr描述中写一下开启单测的比例 |
0x45f
approved these changes
Nov 27, 2023
SecretXV
pushed a commit
to SecretXV/Paddle
that referenced
this pull request
Nov 28, 2023
…arginRankingLoss into pir (PaddlePaddle#58832)
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
APIs
Description
新IR Python API适配升级 #58067
test_bce_with_logits_loss.py单测通过率 4/4test_nn_margin_rank_loss单测通过率 7/13在
create_test_case函数中创建多个MarginRankingLossCls类,run_static_api函数未添加test_with_pir_api装饰器，由于PIR模式下不支持*.nametest_nll_loss, 单测通过率 6/7TestNLLLossName.test_name未开启，PIR模式下不支持*.nametest_sigmoid_cross_entropy_with_logits_op单测通过率 8/9test/legacy_test/test_sigmoid_cross_entropy_with_logits_op.py文件中TestSigmoidCrossEntropyWithLogitsOpError.test_errors未开启