[Dy2St] pir dy2st unittest verification - Part 2 #58686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
reviewed
Nov 6, 2023
Comment on lines
103
to
110
| def to_pir_api_test(fn): | ||
| @wraps(fn) | ||
| def impl(*args, **kwargs): | ||
| logger.info("[PIR][AST] running pir api") | ||
| logger.info("[PIR] running pir api") | ||
| ir_outs = None | ||
| try: | ||
| with paddle.pir_utils.IrGuard(): | ||
| paddle.disable_static() | ||
| ir_outs = fn(*args, **kwargs) | ||
| finally: | ||
| paddle.enable_static() | ||
| with paddle.pir_utils.IrGuard(): | ||
| paddle.disable_static() | ||
| ir_outs = fn(*args, **kwargs) |
There was a problem hiding this comment.
挪到 to_pir_exe_test 下面，相关代码都按照「老 IR」、「中间态」、「最终态」的顺序作为规范
| @wraps(fn) | ||
| def impl(*args, **kwargs): | ||
| logger.info("[PIR] running pir") | ||
| logger.info("[PIR] running pir exe") |
There was a problem hiding this comment.
Suggested change
| logger.info("[PIR] running pir exe") | |
| logger.info("[PIR_EXE] running pir exe") |
| @wraps(fn) | ||
| def impl(*args, **kwargs): | ||
| logger.info("[PIR][AST] running pir api") | ||
| logger.info("[PIR] running pir api") |
There was a problem hiding this comment.
Suggested change
| logger.info("[PIR] running pir api") | |
| logger.info("[PIR_API] running pir api") |
| @@ -284,12 +281,12 @@ def test_legacy_and_pir(fn): | |||
|
|
|||
|
|
|||
| def test_legacy_and_pir_api(fn): | |||
| fn = set_ir_mode(IrMode.LEGACY_IR | IrMode.PIR_API) | |||
| fn = set_ir_mode(IrMode.LEGACY_IR | IrMode.PIR_API)(fn) | |||
| return fn | |||
|
|
|||
|
|
|||
| def test_legacy_and_pir_api_and_pir_exe(fn): | |||
There was a problem hiding this comment.
Suggested change
| def test_legacy_and_pir_api_and_pir_exe(fn): | |
| def test_legacy_and_pir_exe_and_pir_api(fn): |
| @@ -360,7 +359,7 @@ def test_to_static(self): | |||
| net = ListWithCondNet() | |||
There was a problem hiding this comment.
这个单测……应该有控制流吧，按理说最终态的控制流是还不支持的，这个单测为啥过了呢？我稍后看看
test/dygraph_to_static/test_utils.py
Outdated
There was a problem hiding this comment.
这个单测看起来只是测试 utils 功能函数的，所以与 IR 是无关的
但为了保险，我们测一下 legacy 和最终态吧，中间态没必要测
jiahy0825
pushed a commit
to jiahy0825/Paddle
that referenced
this pull request
Nov 7, 2023
--------- Co-authored-by: SigureMo <[email protected]>
zeroRains
pushed a commit
to zeroRains/Paddle
that referenced
this pull request
Nov 8, 2023
--------- Co-authored-by: SigureMo <[email protected]>
This was referenced Nov 9, 2023
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
--------- Co-authored-by: SigureMo <[email protected]>
This was referenced Nov 14, 2023
This was referenced Nov 21, 2023
This was referenced Nov 22, 2023
SecretXV
pushed a commit
to SecretXV/Paddle
that referenced
this pull request
Nov 28, 2023
--------- Co-authored-by: SigureMo <[email protected]>
This was referenced Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
开放部分单测测试
PIR_API修复
test_legacy_and_pir_api_and_pir_exe不生成单测的问题修改方法名称:
to_pir_ast_test->to_pir_api_testto_pir_test->to_pir_exe_test相关链接: