Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docathon][Fix System Message No.7、11、25、28] #58508

Merged
merged 15 commits into from
Nov 6, 2023
Merged

[Docathon][Fix System Message No.7、11、25、28] #58508

merged 15 commits into from
Nov 6, 2023

Conversation

Sekiro-x
Copy link
Contributor

@Sekiro-x Sekiro-x commented Oct 30, 2023

PR types

Others

PR changes

Docs

Description

修复device/Stream_en中的System Message:Warning/ErrorDocathon 英文文档格式修复https://github.com//issues/58237

Copy link
Contributor

@ooooo-create ooooo-create left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

问题应该是 Parameters: 前面没有空行导致的,Returns:Examples: 前面也应该留有空行。
@sunzhongkai588 此外发现此文件中存在许多没有空行却没有显示system message的错误,类似于只有一行的情况,其实还是缺失空行导致的
图片

@Sekiro-x
Copy link
Contributor Author

问题应该是 前面没有空行导致的, 和 前面也应该留有空行。 此外发现此文件中存在许多没有空行却没有显示system message的错误,类似于只有一行的情况,其实还是缺失空行导致的Parameters:``Returns:``Examples: 图片

那我把这个文件的空行都加上吗

@sunzhongkai588
Copy link
Contributor

那我把这个文件的空行都加上吗

参考模板加空行,这里的 Parameters: 其实应该是 Args:

Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

小问题修一下。

另外,如果有时间也可以把 device 下其他的文档也顺便修一下嘿嘿
image

python/paddle/device/__init__.py Outdated Show resolved Hide resolved
python/paddle/device/__init__.py Outdated Show resolved Hide resolved
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Nov 2, 2023
sunzhongkai588
sunzhongkai588 previously approved these changes Nov 3, 2023
Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for docs

解决一下Codestyle的CI问题~(使用 pre-commit 即可)

@sunzhongkai588 sunzhongkai588 changed the title [Docathon][Fix System Message No.28] [Docathon][Fix System Message No.7、11、25、28] Nov 3, 2023
@luotao1 luotao1 merged commit 773dac1 into PaddlePaddle:develop Nov 6, 2023
@Sekiro-x Sekiro-x deleted the my-cool-stuff branch November 6, 2023 07:17
zeroRains pushed a commit to zeroRains/Paddle that referenced this pull request Nov 8, 2023
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
SecretXV pushed a commit to SecretXV/Paddle that referenced this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants