Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Complex OP】No.44 complex support hardswish op #57638

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

yangguohao
Copy link
Contributor

PR types

Others

PR changes

OPs

Description

support complex for hardswish

#56145

@paddle-bot
Copy link

paddle-bot bot commented Sep 22, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Sep 22, 2023
@luotao1 luotao1 added the HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务 label Sep 22, 2023
@yangguohao
Copy link
Contributor Author

@GGBond8488 您好 CI 都过了,麻烦 review 下

typename dOut,
typename dX>
void operator()(Device d, X x, Out out UNUSED, dOut dout, dX dx) const {
auto tmp = ((x + static_cast<ComplexType<T>>(offset)) <
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里写的太乱了,和下面的GPU一样吧,中间变量先cast一次,把公式注释在上面

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

Copy link
Contributor

@GGBond8488 GGBond8488 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit ff54aae into PaddlePaddle:develop Sep 26, 2023
risemeup1 pushed a commit to risemeup1/Paddle that referenced this pull request Sep 26, 2023
Frida-a pushed a commit to Frida-a/Paddle that referenced this pull request Oct 14, 2023
jiahy0825 pushed a commit to jiahy0825/Paddle that referenced this pull request Oct 16, 2023
@yangguohao yangguohao deleted the complex_hardswish branch November 8, 2023 07:55
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
* complex support hardswish op

* fix 2023-09-25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants