-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【Complex OP】No.44 complex support hardswish op #57638
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
@GGBond8488 您好 CI 都过了,麻烦 review 下 |
typename dOut, | ||
typename dX> | ||
void operator()(Device d, X x, Out out UNUSED, dOut dout, dX dx) const { | ||
auto tmp = ((x + static_cast<ComplexType<T>>(offset)) < |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里写的太乱了,和下面的GPU一样吧,中间变量先cast一次,把公式注释在上面
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修改
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* complex support hardswish op * fix 2023-09-25
* complex support hardswish op * fix 2023-09-25
* complex support hardswish op * fix 2023-09-25
* complex support hardswish op * fix 2023-09-25
PR types
Others
PR changes
OPs
Description
support complex for hardswish
#56145