Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【complex op】 No.34 add complex support for dot #56349

Merged
merged 4 commits into from
Aug 17, 2023

Conversation

huangjiyi
Copy link
Member

PR types

Others

PR changes

Others

Description

改动:

  • op dot 的前向及反向 kernel 已经支持复数类型,无需改动
  • 在 dot api 的类型校验中增加了复数
  • 改写 op dot 的复数单测

@paddle-bot
Copy link

paddle-bot bot commented Aug 16, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Aug 16, 2023
@huangjiyi huangjiyi changed the title [complex op] No.34 add complex support for dot 【complex op】 No.34 add complex support for dot Aug 17, 2023
@huangjiyi
Copy link
Member Author

@ScottWong98 ,帮忙 Review 一下 ~

Copy link
Contributor

@ScottWong98 ScottWong98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@GGBond8488 GGBond8488 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 920c66e into PaddlePaddle:develop Aug 17, 2023
@luotao1
Copy link
Contributor

luotao1 commented Aug 17, 2023

@huangjiyi 请补充中文文档

@luotao1 luotao1 added HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务 and removed HappyOpenSource 快乐开源活动issue与PR labels Sep 6, 2023
@huangjiyi huangjiyi deleted the dot_support_complex branch January 9, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants