-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update annotations of layers.py #5487
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
for details. | ||
:type inproj_param_attr: ParameterAttribute | ||
:param inproj_bias_attr: The bias attribute of the projection. If the parameter is set to | ||
False or something not type of ParameterAttribute, no bias is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
把 "something not type of ParameterAttribute," 改为 If this parameter is set False or an object whose type is not ParameterAttribute 吧~ 原来那句话有语法错误。
其它出现地方相同。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@@ -6436,34 +6432,34 @@ def gated_unit_layer(input, | |||
|
|||
:param input: The input of this layer. | |||
:type input: LayerOutput | |||
:param size: output size of the gated unit. | |||
:param size: The dimemsion of this layer's output. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a type: dimension.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT, thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you.
@lcy-seso