Adding the doc format for AdaDelta, AdaMax, Adam, AdaGrad, BatchNorm, Clip, Cast and AUC #5317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavyasrinet
changed the title
abhinavarora
reviewed
Nov 2, 2017
paddle/operators/adadelta_op.cc
Outdated
|
|
||
| This implements the Adadelta optimizer[1]. Adadelta is a per-dimension | ||
| adaptive learning rate method for gradient descent. | ||
| We implement the Adadelta optimizer as explained in: |
There was a problem hiding this comment.
Do you think we should use the first person here?
There was a problem hiding this comment.
Fixed. Thanks for the comment.
wangkuiyi
previously approved these changes
Nov 3, 2017
kavyasrinet
changed the title
kexinzhao
reviewed
Nov 4, 2017
paddle/operators/cast_op.cc
Outdated
| AddAttr<int>("out_data_type", "output data type"); | ||
| AddAttr<int>("in_data_type", "input data type"); | ||
| AddComment(R"DOC( | ||
| Cast operator. |
There was a problem hiding this comment.
Done. Thanks for pointing that out.
wangkuiyi
approved these changes
Nov 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the proposed documentation format for AdaDelta.
Let's follow the same going forward for all operators.
The operators in this PR are: