Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine sequence max-pooling and add unit testing of gradient check. #5310

Merged
merged 7 commits into from
Nov 6, 2017
Merged

Refine sequence max-pooling and add unit testing of gradient check. #5310

merged 7 commits into from
Nov 6, 2017

Conversation

qingqing01
Copy link
Contributor

@qingqing01 qingqing01 commented Nov 2, 2017 •
edited
Loading

Fix #5311

luotao1
luotao1 approved these changes Nov 6, 2017
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 0977cbf into PaddlePaddle:develop Nov 6, 2017
@qingqing01 qingqing01 deleted the fix_max_pool branch March 7, 2018 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luotao1 luotao1 luotao1 approved these changes

@reyoung reyoung Awaiting requested review from reyoung

@JiayiFeng JiayiFeng Awaiting requested review from JiayiFeng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qingqing01 @luotao1