【Hackathon No.89】 Remove circle import Part5 #51881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Liyulingyue
changed the title
|
@Aurelius84 见python/paddle/jit/dy2static/utils_helper.py L70，该底层逻辑引用了自身import paddle.jit.dy2static as _jst # noqa: F401 用作引用判断。此处可能不易于解耦。 |
Aurelius84
reviewed
Mar 22, 2023
python/paddle/jit/dy2static/utils.py
Outdated
| @@ -31,6 +31,7 @@ | |||
| import numpy as np | |||
|
|
|||
| import paddle | |||
| import paddle.fluid as fluid # noqa: F401 | |||
There was a problem hiding this comment.
utils 用到的只有fluid.dygraph.Layer，是在一个eval里，所以这里需要加F401，但这个import语句是不是可以删掉？我看399行已经改为了paddle.nn.Layer了
There was a problem hiding this comment.
如果后续还有part6的PR，也可以放到下个PR里修改。
There was a problem hiding this comment.
如果后续还有part6的PR，也可以放到下个PR里修改。
收到～ 该问题在下个pr中解决～
|
和 @Aurelius84 沟通确认：No.89 任务已完成 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
Details
本PR修复了部分显而易见的循环引用问题。