Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fp16] suppot fp16 in diagflat #50945

Merged
merged 4 commits into from
Mar 1, 2023
Merged

[fp16] suppot fp16 in diagflat #50945

merged 4 commits into from
Mar 1, 2023

Conversation

longranger2
Copy link
Contributor

@longranger2 longranger2 commented Feb 27, 2023 •
edited
Loading

PR types

Others

PR changes

APIs

Describe

#50832 case32
对应的中文文档为: PaddlePaddle/docs#5668

@paddle-bot
Copy link

paddle-bot bot commented Feb 27, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Feb 27, 2023
@paddle-bot
Copy link

paddle-bot bot commented Feb 27, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

@zhangting2020 zhangting2020 mentioned this pull request Feb 27, 2023
Closed
zhangting2020
zhangting2020 reviewed Feb 27, 2023
View reviewed changes
python/paddle/fluid/tests/unittests/test_diagflat.py Outdated
},
fetch_list=[y],
)
np.testing.assert_allclose(res, expected, rtol=1e-05)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看ci由于精度检查失败了。本次任务暂不要求对精度做检查，可以先去掉这个精度检查，或者通过调大rtol让单测通过

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK👌

@Liyulingyue
Copy link
Contributor

Liyulingyue commented Feb 27, 2023 •
edited
Loading 

<!-- Demo: https://github.com/PaddlePaddle/Paddle/pull/24810 -->
### PR types
<!-- One of [ New features | Bug fixes | Function optimization | Performance optimization | Breaking changes | Others ] -->
Others 
### PR changes
<!-- One of [ OPs | APIs | Docs | Others ] -->
Others 
### Describe
<!-- Describe what this PR does -->
Others

PR描述中如果不使用三级标题可能会CI报错。记得改一下~示例如上

@longranger2
Copy link
Contributor Author

longranger2 commented Feb 27, 2023 •
edited
Loading 

<!-- Demo: https://github.com/PaddlePaddle/Paddle/pull/24810 -->
### PR types
<!-- One of [ New features | Bug fixes | Function optimization | Performance optimization | Breaking changes | Others ] -->
Others 
### PR changes
<!-- One of [ OPs | APIs | Docs | Others ] -->
Others 
### Describe
<!-- Describe what this PR does -->
Others

PR描述中如果不使用三级标题可能会CI报错。记得改一下~示例如上

修改好了～

Update test_diagflat.py
f768625 
remove precison checking
zhangting2020
zhangting2020 approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@zhangting2020 zhangting2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit af149c0 into PaddlePaddle:develop Mar 1, 2023
@luotao1
Copy link
Contributor

luotao1 commented Mar 1, 2023

@longranger2 中文文档修改请补充上 PR 链接

@longranger2
Copy link
Contributor Author

@longranger2 中文文档修改请补充上 PR 链接

好的，今天搞定👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangting2020 zhangting2020 zhangting2020 approved these changes

Assignees

@luotao1 luotao1

@zhangting2020 zhangting2020

Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@longranger2 @Liyulingyue @luotao1 @zhangting2020