Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UFA非法地址访问(UFA illegal address access) of case2: paddle.scatter #50025

Merged
merged 4 commits into from
Feb 10, 2023
Merged

Fix UFA非法地址访问(UFA illegal address access) of case2: paddle.scatter #50025

merged 4 commits into from
Feb 10, 2023

Conversation

RedContritio
Copy link
Contributor

PR types

Bug fixes

PR changes

OPs

Describe

Solution

  • 在 C++ 端添加了对 _index 的右边界检查（之前为啥只有左边界检查啊？不考虑对称性吗

@paddle-bot
Copy link

paddle-bot bot commented Jan 25, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Jan 25, 2023
@luotao1 luotao1 mentioned this pull request Jan 25, 2023
Closed
@CLAassistant
Copy link

CLAassistant commented Feb 2, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@RedContritio
Copy link
Contributor Author

__CUDA_ARCH__下的PADDLE_ENFORCE尚不支持声明错误类型

所以在单测里做了区分

wanghuancoder
wanghuancoder reviewed Feb 6, 2023
View reviewed changes
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

麻烦给这个case加一个单测吧

@RedContritio
Copy link
Contributor Author

麻烦给这个case加一个单测吧

已添加，待 Approve

wanghuancoder
wanghuancoder previously approved these changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有点儿小建议，最好修改一下。着急合入也可以合入。
这个对scatter的改动不小。一定让API负责人再Review一下。

paddle/phi/kernels/funcs/scatter.cu.h Outdated Show resolved Hide resolved
paddle/phi/kernels/funcs/scatter.cu.h Outdated Show resolved Hide resolved
FeixLiu
FeixLiu previously approved these changes Feb 10, 2023
View reviewed changes
@luotao1 luotao1 merged commit fb228c4 into PaddlePaddle:develop Feb 10, 2023
@RedContritio RedContritio deleted the scatter branch February 13, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luotao1 luotao1 luotao1 approved these changes

@wanghuancoder wanghuancoder wanghuancoder left review comments

@FeixLiu FeixLiu FeixLiu left review comments

Assignees

@luotao1 luotao1

@FeixLiu FeixLiu

@wanghuancoder wanghuancoder

Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RedContritio @CLAassistant @luotao1 @FeixLiu @wanghuancoder