-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix div 0 error in conv1/2/3 #49999
fix div 0 error in conv1/2/3 #49999
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2023-01-22 16:18:35 847 - test_functional_conv1d (Failed)
2023-01-22 16:18:35 849 - test_functional_conv2d (Failed)
2023-01-22 16:18:35 851 - test_functional_conv3d (Failed)
请修复下Coverage流水线新增单测失败的问题
@wanghuancoder 意见:你的这个问题。我在我本机调试仍然是:issue给的case、单测都报CUDNN_STATUS_BAD_PARAM。和CI的现象一致。而且,就算没有加你对paddle/phi/kernels/impl/conv_kernel_impl.h的修改代码。报错也是CUDNN_STATUS_BAD_PARAM。所以,我觉得还是你的检查没有生效。我觉得对一个没有任何数据的Tensor做卷积本身就是没意义的。所以请@wangxinxin08 一起看下是不是对输入进行一下检查比较好。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
推荐在ConvInferMeta: https://github.com/PaddlePaddle/Paddle/blob/develop/paddle/phi/infermeta/binary.cc#L443 中进行输入shape不合法的判断,避免不合法的输入进入kernel浪费时间且导致错误
PR types
Bug fixes
PR changes
APIs
Describe