Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix div 0 error in conv1/2/3 #49999

Merged
merged 6 commits into from
Feb 7, 2023
Merged

Conversation

Liyulingyue
Copy link
Contributor

PR types

Bug fixes

PR changes

APIs

Describe

@paddle-bot
Copy link

paddle-bot bot commented Jan 22, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

wanghuancoder
wanghuancoder previously approved these changes Jan 30, 2023
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2023-01-22 16:18:35             	847 - test_functional_conv1d (Failed)
2023-01-22 16:18:35             	849 - test_functional_conv2d (Failed)
2023-01-22 16:18:35             	851 - test_functional_conv3d (Failed)

请修复下Coverage流水线新增单测失败的问题

@luotao1
Copy link
Contributor

luotao1 commented Feb 6, 2023

@wanghuancoder 意见:你的这个问题。我在我本机调试仍然是:issue给的case、单测都报CUDNN_STATUS_BAD_PARAM。和CI的现象一致。而且,就算没有加你对paddle/phi/kernels/impl/conv_kernel_impl.h的修改代码。报错也是CUDNN_STATUS_BAD_PARAM。所以,我觉得还是你的检查没有生效。我觉得对一个没有任何数据的Tensor做卷积本身就是没意义的。所以请@wangxinxin08 一起看下是不是对输入进行一下检查比较好。

image

Copy link
Contributor

@wangxinxin08 wangxinxin08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

推荐在ConvInferMeta: https://github.com/PaddlePaddle/Paddle/blob/develop/paddle/phi/infermeta/binary.cc#L443 中进行输入shape不合法的判断,避免不合法的输入进入kernel浪费时间且导致错误

@luotao1 luotao1 merged commit 7a0fdeb into PaddlePaddle:develop Feb 7, 2023
@Liyulingyue Liyulingyue deleted the div0_28 branch February 21, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants