Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Python IndexError of case16: paddle.nn.functional.max_unpool2d/max_unpool3d #49991

Merged
merged 2 commits into from
Feb 2, 2023
Merged

Fix Python IndexError of case16: paddle.nn.functional.max_unpool2d/max_unpool3d #49991

merged 2 commits into from
Feb 2, 2023

Conversation

RedContritio
Copy link
Contributor

PR types

Bug fixes

PR changes

APIs

Describe

Solution

  • 限制 x.ndim 和 indices.ndim 为对应函数说明中的值

@paddle-bot
Copy link

paddle-bot bot commented Jan 21, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Jan 21, 2023
@luotao1 luotao1 mentioned this pull request Jan 22, 2023
Closed
wanghuancoder
wanghuancoder reviewed Jan 30, 2023
View reviewed changes
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

给这两种场景加个单测吧，感谢！

@paddle-bot
Copy link

paddle-bot bot commented Jan 31, 2023

很抱歉，经过我们的反复讨论，你的PR暂未达到合入标准，请阅读飞桨原生算子开发规范，你可以重新提交新的PR，我们先将此PR关闭，感谢你的贡献。
Sorry to inform you that through our discussion, your PR fails to meet the merging standard (Reference: Paddle Custom Operator Design Doc). You can also submit an new one. Thank you.

@RedContritio RedContritio reopened this Jan 31, 2023
@RedContritio
Copy link
Contributor Author

RedContritio commented Jan 31, 2023 •
edited
Loading

给这两种场景加个单测吧，感谢！

@wanghuancoder

误操作关闭 PR 了，reopen 了一下，单测已添加

wanghuancoder
wanghuancoder approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tink2123
tink2123 approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@tink2123 tink2123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 636780b into PaddlePaddle:develop Feb 2, 2023
@RedContritio RedContritio deleted the max_unpool branch February 13, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanghuancoder wanghuancoder wanghuancoder approved these changes

@tink2123 tink2123 tink2123 approved these changes

Assignees

@luotao1 luotao1

@wanghuancoder wanghuancoder

@tink2123 tink2123

Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RedContritio @wanghuancoder @tink2123 @luotao1