Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Python IndexError of case8: paddle.static.nn.nce #49989

Merged
merged 3 commits into from
Feb 2, 2023
Merged

Fix Python IndexError of case8: paddle.static.nn.nce #49989

merged 3 commits into from
Feb 2, 2023

Conversation

RedContritio
Copy link
Contributor

PR types

Bug fixes

PR changes

APIs

Describe

Solution

  • 限制 input.ndim == 2

@paddle-bot
Copy link

paddle-bot bot commented Jan 21, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Jan 21, 2023
@luotao1 luotao1 mentioned this pull request Jan 22, 2023
Closed
wanghuancoder
wanghuancoder reviewed Jan 30, 2023
View reviewed changes
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

给这个case加个单测吧，感谢

@RedContritio
Copy link
Contributor Author

给这个case加个单测吧，感谢

已添加

wanghuancoder
wanghuancoder previously approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pangyoki
pangyoki previously approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@pangyoki pangyoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1
Copy link
Contributor

luotao1 commented Feb 1, 2023

请修复下windows-openblas流水线中test_nce失败的问题

@RedContritio RedContritio dismissed stale reviews from pangyoki and wanghuancoder via 6887e82 February 1, 2023 11:59
@luotao1 luotao1 merged commit c8548af into PaddlePaddle:develop Feb 2, 2023
@RedContritio RedContritio deleted the nce branch February 13, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luotao1 luotao1 luotao1 approved these changes

@pangyoki pangyoki pangyoki left review comments

@wanghuancoder wanghuancoder wanghuancoder left review comments

Assignees

@luotao1 luotao1

@pangyoki pangyoki

@wanghuancoder wanghuancoder

Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RedContritio @luotao1 @pangyoki @wanghuancoder