Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 堆栈溢出 (stack overflow) of case8: paddle.unique_consecutive #49983

Merged
merged 3 commits into from
Feb 3, 2023
Merged

Fix 堆栈溢出 (stack overflow) of case8: paddle.unique_consecutive #49983

merged 3 commits into from
Feb 3, 2023

Conversation

RedContritio
Copy link
Contributor

PR types

Bug fixes

PR changes

OPs

Describe

Solution

添加对负数 axis 的支持

@paddle-bot
Copy link

paddle-bot bot commented Jan 21, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为这个case加个单测吧

@RedContritio
Copy link
Contributor Author

#49978 合入之后,再在其单测文件基础上进行用例的添加,以避免产生冲突

@luotao1
Copy link
Contributor

luotao1 commented Jan 31, 2023

#49978 合入之后,再在其单测文件基础上进行用例的添加,以避免产生冲突

#49978 已经merge

@RedContritio
Copy link
Contributor Author

#49978 合入之后,再在其单测文件基础上进行用例的添加,以避免产生冲突

#49978 已经merge

已添加单测,待 review @wanghuancoder

Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@GuoxiaWang GuoxiaWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 83077f6 into PaddlePaddle:develop Feb 3, 2023
@RedContritio RedContritio deleted the unique_consecutive2 branch February 13, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants