Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix div 0 error of fftfreq #49954

Merged
merged 4 commits into from
Jan 26, 2023
Merged

fix div 0 error of fftfreq #49954

merged 4 commits into from
Jan 26, 2023

Conversation

Liyulingyue
Copy link
Contributor

@Liyulingyue Liyulingyue commented Jan 19, 2023 •
edited
Loading

PR types

Bug fixes

PR changes

APIs

Describe

解决思路

  • 错误：输入参数的计算结果做除数，除数不能为0，报错
  • 解决：
    • 在计算前增加数值检查，如果为0抛出错误和修改提
    • 增加单测，分别设计不同的参数输入组合，验证0除报错语句是否能够执行

@paddle-bot
Copy link

paddle-bot bot commented Jan 19, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Jan 19, 2023
@luotao1 luotao1 mentioned this pull request Jan 19, 2023
Closed
@Liyulingyue Liyulingyue mentioned this pull request Jan 20, 2023
Merged
wanghuancoder
wanghuancoder approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iclementine iclementine merged commit 7a0b0da into PaddlePaddle:develop Jan 26, 2023
pangengzheng pushed a commit to pangengzheng/Paddle that referenced this pull request Feb 2, 2023
@Liyulingyue @pangengzheng
fix div 0 error of fftfreq (PaddlePaddle#49954)
f5cf498 
* fix div 0 error of fftfreq

* fix div 0 error of fftfreq

* bug fix

* add 'n' value check
@Liyulingyue Liyulingyue deleted the div0_34 branch February 21, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanghuancoder wanghuancoder wanghuancoder approved these changes

@iclementine iclementine iclementine approved these changes

Assignees

@luotao1 luotao1

@iclementine iclementine

@wanghuancoder wanghuancoder

Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Liyulingyue @iclementine @wanghuancoder @luotao1