Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHI decoupling] move gather_scatter_kernel from fluid to phi #49132

Merged
merged 2 commits into from
Dec 19, 2022
Merged

[PHI decoupling] move gather_scatter_kernel from fluid to phi #49132

merged 2 commits into from
Dec 19, 2022

Conversation

huangjiyi
Copy link
Member

@huangjiyi huangjiyi commented Dec 16, 2022 •
edited
Loading

PR types

Others

PR changes

Others

Describe

@paddle-bot
Copy link

paddle-bot bot commented Dec 16, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Dec 16, 2022
@huangjiyi
Copy link
Member Author

@YuanRisheng 帮忙 Review 一下

YuanRisheng
YuanRisheng reviewed Dec 19, 2022
View reviewed changes
Copy link
Contributor

@YuanRisheng YuanRisheng left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

把gather_scatter_kernel文件挪动到funcs目录下把，并改名gather_scatter_functor。Phi下的cpu/gpu目录下的xxx_kernel文件，指的是正式注册过的算子Kernel，Fluid下的gather_scatter_kernel不是此性质的文件，挪动到Phi下后需要改名防止误解

@huangjiyi huangjiyi closed this Dec 19, 2022
@huangjiyi huangjiyi reopened this Dec 19, 2022
@paddle-bot
Copy link

paddle-bot bot commented Dec 19, 2022

很抱歉，经过我们的反复讨论，你的PR暂未达到合入标准，请阅读飞桨原生算子开发规范，你可以重新提交新的PR，我们先将此PR关闭，感谢你的贡献。
Sorry to inform you that through our discussion, your PR fails to meet the merging standard (Reference: Paddle Custom Operator Design Doc). You can also submit an new one. Thank you.

@huangjiyi
Copy link
Member Author

把gather_scatter_kernel文件挪动到funcs目录下把，并改名gather_scatter_functor。Phi下的cpu/gpu目录下的xxx_kernel文件，指的是正式注册过的算子Kernel，Fluid下的gather_scatter_kernel不是此性质的文件，挪动到Phi下后需要改名防止误解

明白了，已处理

@huangjiyi
Copy link
Member Author

@YuanRisheng，帮忙再 Review 一下

@huangjiyi
Copy link
Member Author

@luotao1 帮忙处理下 CI-Coverage

@luotao1 luotao1 merged commit 0b79129 into PaddlePaddle:develop Dec 19, 2022
@luotao1 luotao1 mentioned this pull request Dec 19, 2022
Closed
@huangjiyi huangjiyi deleted the decouple_gather_scatter branch March 8, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuanRisheng YuanRisheng YuanRisheng approved these changes

Assignees
No one assigned
Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huangjiyi @YuanRisheng @luotao1