-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CodeStyle][isort] introduce isort (part4) #48402
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
32d4cc4
to
2e5d54a
Compare
31b5d03
to
e60f7c6
Compare
e60f7c6
to
e473442
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@SigureMo 请解决下冲突 |
@luotao1 这个 CI 也跑完啦~ |
isort 工作也可以放到 Flake8 tracking issue 的其他成果中 |
嗯嗯,Flake8 tracking issue 有这一部分,不过后面的我还没整理,等 part6 merge 后我一起整理下~ |
* isort all files * revert conflicting files * revert conflicting files * revert conflicting files
PR types
Others
PR changes
Others
Describe
引入 isort 第四部分,格式化非单测部分代码(视情况可能进一步拆分……)
因为出问题已经 revert 的一些目录,将会在之后 PR 查明问题并格式化:
python/paddle/tensor
python/paddle/common_ops_import.py
(为解决上面的循环依赖而和上面一起修改,不在本 PR 修改)本 PR 直接加一个python/paddle/utils/cpp_extension/cpp_extension.py
isort: skip_file
解决Related links
isort
(part1) #46475