Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHI] Migrate batch_norm_grad kernel #48288

Merged
merged 1 commit into from
Nov 24, 2022
Merged

[PHI] Migrate batch_norm_grad kernel #48288

merged 1 commit into from
Nov 24, 2022

Conversation

Silv3S
Copy link
Member

@Silv3S Silv3S commented Nov 23, 2022

PR types

Others

PR changes

Others

Describe

  • migrate batch_norm_grad kernel to PHI,
  • update error messages.

@paddle-bot
Copy link

paddle-bot bot commented Nov 23, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Nov 23, 2022
@Silv3S Silv3S added Intel and removed contributor External developers status: proposed labels Nov 23, 2022
@Silv3S Silv3S mentioned this pull request Nov 23, 2022
Closed
@Silv3S
Copy link
Member Author

Silv3S commented Nov 23, 2022

@YuanRisheng could you please review?

@Silv3S Silv3S requested a review from YuanRisheng November 23, 2022 18:01
@paddle-bot-old paddle-bot-old bot added the contributor External developers label Nov 23, 2022
@Silv3S
Copy link
Member Author

Silv3S commented Nov 23, 2022

@luotao1 could you please approve modifying unity_build_rule.cmake?

luotao1
luotao1 approved these changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for unity_build_rule.cmake

@luotao1 luotao1 merged commit 561b727 into PaddlePaddle:develop Nov 24, 2022
@Silv3S Silv3S deleted the phi_batch_norm_grad_kernel branch November 24, 2022 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luotao1 luotao1 luotao1 approved these changes

@YuanRisheng YuanRisheng YuanRisheng approved these changes

Assignees
No one assigned
Labels
contributor External developers Intel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Silv3S @luotao1 @YuanRisheng