[PHI decoupling] remove dependency on "paddle/fluid/operators/elementwise/xxx.h" in phi #47870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
YuanRisheng
reviewed
Nov 11, 2022
| @@ -882,6 +882,38 @@ void ElementwiseKernel(const KPDevice &ctx, | |||
| } | |||
| } | |||
|
|
|||
| template <typename OutT, typename Functor, int NumOuts = 1> | |||
| void LaunchSameDimsElementwiseCudaKernel( | |||
There was a problem hiding this comment.
不需要把这个函数移过来，通过分析其逻辑可以看出，其本质调用的ElementwiseKernel，所以直接把使用这个函数的地方替换成ElementwiseKernel即可，另外如果后续需要移动函数，需要把原函数删掉，防止维护重复代码，增加工作量
|
@YuanRisheng 修改后的 CI 已经全部通过，可以再次 review 了。 |
YuanRisheng
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
remove dependency on "paddle/fluid/operators/elementwise/xxx.h" in phi, including
elementwise_op_function.handelementwise_op_impl.cu.h.changes:
#include "paddle/fluid/operators/elementwise/elementwise_op_impl.cu.h"替换为#include "paddle/phi/kernels/funcs/elementwise_base.h".paddle::operators:LaunchSameDimsElementwiseCudaKernel替换为phi::funcs::ElementwiseKernelviterbi_decode_kernel.cu中的#include "paddle/fluid/operators/elementwise/elementwise_op_function.h"，并将paddle::operators::LaunchElementwiseCudaKernel替换为phi::funcs::BroadcastKernel，同时添加#include "paddle/phi/kernels/funcs/broadcast_function.h".