[phi] migrate prelu #47422
Merged
[phi] migrate prelu #47422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfraczek
force-pushed
the
migrate-prelu-v2
branch
from
1edb7fe to
a5692e2
Compare
sfraczek
force-pushed
the
migrate-prelu-v2
branch
from
a5692e2 to
99504cb
Compare
|
很抱歉，经过我们的反复讨论，你的PR暂未达到合入标准，请阅读飞桨原生算子开发规范，你可以重新提交新的PR，我们先将此PR关闭，感谢你的贡献。 |
Silv3S
previously approved these changes
Nov 8, 2022
Comment on lines
1083
to
1084
| PReluOneDNNHandler(const OneDNNContext& dev_ctx, | ||
| const dnnl::engine engine, |
There was a problem hiding this comment.
Suggested change
| PReluOneDNNHandler(const OneDNNContext& dev_ctx, | |
| const dnnl::engine engine, | |
| PReluOneDNNHandler(const dnnl::engine engine, |
No need to pass whole OneDNNContext to handler, as you already extracted engine, place and is_test in both kernels
| @@ -0,0 +1,60 @@ | |||
| /* Copyright (c) 2021 PaddlePaddle Authors. All Rights Reserved. | |||
| PADDLE_ENFORCE_EQ( | ||
| dev_ctx.GetPlace().GetType(), | ||
| AllocationType::CPU, | ||
| phi::errors::PreconditionNotMet("Operator DNNL PReLU must use CPUPlace")); |
YuanRisheng
approved these changes
Nov 10, 2022
piotrekobi
approved these changes
Nov 10, 2022
Comment on lines
+1
to
+10
| /* Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved. | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. */ |
There was a problem hiding this comment.
Suggested change
| /* Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved. | |
| Licensed under the Apache License, Version 2.0 (the "License"); | |
| you may not use this file except in compliance with the License. | |
| You may obtain a copy of the License at | |
| http://www.apache.org/licenses/LICENSE-2.0 | |
| Unless required by applicable law or agreed to in writing, software | |
| distributed under the License is distributed on an "AS IS" BASIS, | |
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |
| See the License for the specific language governing permissions and | |
| limitations under the License. */ | |
| // Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved. | |
| // | |
| // Licensed under the Apache License, Version 2.0 (the "License"); | |
| // you may not use this file except in compliance with the License. | |
| // You may obtain a copy of the License at | |
| // | |
| // http://www.apache.org/licenses/LICENSE-2.0 | |
| // | |
| // Unless required by applicable law or agreed to in writing, software | |
| // distributed under the License is distributed on an "AS IS" BASIS, | |
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |
| // See the License for the specific language governing permissions and | |
| // limitations under the License. |
Please use this license format instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
OPs
Describe
Migrate prelu to phi