Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wsign-compare] Close Wno-error of sign-compare #47252

Merged
merged 5 commits into from
Oct 26, 2022

Conversation

Li-fAngyU
Copy link
Contributor

PR types

Others

PR changes

Others

Describe

Close Wno-error=sign_compare

@paddle-bot
Copy link

paddle-bot bot commented Oct 21, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Oct 21, 2022
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1
Copy link
Contributor

luotao1 commented Oct 24, 2022

Coverage 流水线失败,原因是 #46014 (comment) ,可以merge下最新的develop分支

@luotao1 luotao1 self-assigned this Oct 24, 2022
@Li-fAngyU Li-fAngyU requested a review from luotao1 October 26, 2022 00:53
@luotao1 luotao1 merged commit aab21d1 into PaddlePaddle:develop Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants