Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable hard_swish_grad unit test #46621

Merged
merged 3 commits into from
Oct 9, 2022
Merged

Enable hard_swish_grad unit test #46621

merged 3 commits into from
Oct 9, 2022

Conversation

Silv3S
Copy link
Member

@Silv3S Silv3S commented Sep 28, 2022 •
edited
Loading

PR types

Others

PR changes

Others

Describe

  • enable hard_swish grad unit tests which were skipped,
  • remove unused argument in activation handler.

@paddle-bot
Copy link

paddle-bot bot commented Sep 28, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Sep 28, 2022
@Silv3S Silv3S added the Intel label Sep 28, 2022
This was referenced Sep 28, 2022
Merged
Closed
@Silv3S Silv3S requested a review from YuanRisheng September 28, 2022 20:52
@Silv3S
Copy link
Member Author

Silv3S commented Sep 29, 2022

@zhangting2020 could you please approve removing @skip_check_grad_ci()?

@jakpiase jakpiase self-requested a review September 29, 2022 15:32
jakpiase
jakpiase approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@jakpiase jakpiase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhangting2020
zhangting2020 approved these changes Oct 9, 2022
View reviewed changes
Copy link
Contributor

@zhangting2020 zhangting2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for skip_check_grad_ci

@YuanRisheng YuanRisheng merged commit ff0171e into PaddlePaddle:develop Oct 9, 2022
@Silv3S Silv3S deleted the enable_grad_ut branch October 9, 2022 05:10
@YuanRisheng YuanRisheng mentioned this pull request Oct 10, 2022
Closed
@paddle-bot-old paddle-bot-old bot removed the contributor External developers label Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangting2020 zhangting2020 zhangting2020 approved these changes

@YuanRisheng YuanRisheng YuanRisheng approved these changes

@jakpiase jakpiase jakpiase approved these changes

Assignees
No one assigned
Labels
Intel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Silv3S @zhangting2020 @YuanRisheng @jakpiase