Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHI] relu6_grad kernel #46501

Merged
merged 11 commits into from
Sep 28, 2022
Merged

Conversation

Silv3S
Copy link
Member

@Silv3S Silv3S commented Sep 26, 2022

PR types

Others

PR changes

Others

Describe

  • migrate relu6_grad from fluid to phi,
  • replace deprecated eltwise_bounded_relu with eltwise_clip.

@paddle-bot
Copy link

paddle-bot bot commented Sep 26, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Sep 26, 2022
@Silv3S Silv3S changed the title Phi migration part 6 [PHI] relu6_grad kernel Sep 26, 2022
@Silv3S Silv3S added the Intel label Sep 26, 2022
@Silv3S Silv3S requested a review from piotrekobi September 26, 2022 21:01
Copy link
Contributor

@piotrekobi piotrekobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Silv3S
Copy link
Member Author

Silv3S commented Sep 27, 2022

bouned_relu will be removed from next version of oneDNN, so we decided to implement relu6_grad kernel with clip

@YuanRisheng YuanRisheng merged commit cee2b12 into PaddlePaddle:develop Sep 28, 2022
@Silv3S Silv3S deleted the phi_migration_part_6 branch September 28, 2022 07:09
Silv3S added a commit to Silv3S/Paddle that referenced this pull request Oct 10, 2022
* Relu6

* remove fluid handler

* add individual kernel signature

* coding style

* replace bounded_relu with clip

* whitespace

* code style
phlrain pushed a commit that referenced this pull request Oct 11, 2022
* [PHI] Migrate gelu kernels (#45596)

* gaussian random

* mkldnn to onednn renaming

* fix merge conflicts

* remove fluid code

* onednn renaming

* gelu fwd

* sort activations

* gelu gradient

* remove unused macros

* merge conflicts

* fix merge conflicts

* remove extra contraint from gelu op

* [PHI] relu6_grad kernel (#46501)

* Relu6

* remove fluid handler

* add individual kernel signature

* coding style

* replace bounded_relu with clip

* whitespace

* code style
@paddle-bot-old paddle-bot-old bot removed the contributor External developers label Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants