[PHI] Shape op migration #46051
Merged
[PHI] Shape op migration #46051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@piotrekobi can you review please? |
piotrekobi
suggested changes
Sep 19, 2022
Comment on lines
52
to
53
| PD_REGISTER_KERNEL( | ||
| shape, OneDNN, ALL_LAYOUT, phi::ShapeKernel, float, phi::dtype::bfloat16) {} |
There was a problem hiding this comment.
The original kernel is also registered for the int8 and uint8 types. Please add them as follows:
PD_REGISTER_KERNEL(
shape, OneDNN, ALL_LAYOUT, phi::ShapeKernel, float, phi::dtype::bfloat16, int8_t, uint8_t) {}
|
@chenwhql Please review |
YuanRisheng
approved these changes
Sep 20, 2022
chenwhql
approved these changes
Sep 20, 2022
|
@jczaja I think it's ready to merge |
|
@paulinagacek I cannot merge it till you sort out the problem with license/cla check |
|
你的PR已合入Paddle库，请关注后续测试结果。 |
Silv3S
pushed a commit
to Silv3S/Paddle
that referenced
this pull request
Oct 3, 2022
* First approach * Shape kernel corrected * Compilation error fixed * Resize corrected * Registered types added * Mistake corrected & types added * sum kernel deleted
phlrain
pushed a commit
that referenced
this pull request
Oct 10, 2022
* First approach * Shape kernel corrected * Compilation error fixed * Resize corrected * Registered types added * Mistake corrected & types added * sum kernel deleted Co-authored-by: Paulina Gacek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
migrate OneDNN shape kernel to PHI