Adding Adadelta optimization operator #4576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacquesqiao
reviewed
Oct 5, 2017
paddle/operators/adadelta_op.h
Outdated
| framework::EigenVector<T>::Flatten(*avg_squared_update_out); | ||
| auto place = ctx.GetEigenDevice<Place>(); | ||
|
|
||
| g_acc_out.device(place) = rho * g_acc + (1 - rho) * g.square(); |
There was a problem hiding this comment.
maybe we can name g_acc_out as avg_squared_grad_eigen to be consistent with the formula written in the DOC, it will be better to read and understand
There was a problem hiding this comment.
Sure, I will make the change
There was a problem hiding this comment.
since avg_squared_grad_eigen is a litter too long, we can use avg_squared_grad here and change the formal value avg_squared_grad get from tensor to avg_squared_grad_t or something like this
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.