Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove add_op since it can be replaced by sum_op #4514

Merged
merged 2 commits into from
Sep 30, 2017

Conversation

reyoung
Copy link
Collaborator

@reyoung reyoung commented Sep 29, 2017

No description provided.

@@ -1,46 +0,0 @@
import unittest
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since GradientChecker are widely used now. It does not need to write an independent unit-test.

Copy link
Member

@QiJune QiJune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reyoung reyoung merged commit 0900aed into PaddlePaddle:develop Sep 30, 2017
@reyoung reyoung deleted the feature/remove_add_op branch October 2, 2017 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants