Unify Activation functions and simplify register code #4485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyoung
force-pushed
the
feature/BetterActivationKern
branch
from
f794396 to
337b7eb
Compare
QiJune
reviewed
Sep 29, 2017
| struct BaseActivationFunctor { | ||
| using ELEMENT_TYPE = T; | ||
|
|
||
| using AttrPair = std::vector<std::pair<const char*, float*>>; |
There was a problem hiding this comment.
Why here attr is always float? Attr has its own data type, and will be static_cast to activation functor data type
reyoung
force-pushed
the
feature/BetterActivationKern
branch
from
eec6ed5 to
a8c6ce9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.