[JitLayer]Clean some include and polish load program code #43798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
0x45f
changed the title
Aurelius84
reviewed
Jun 27, 2022
paddle/fluid/jit/function_schema.cc
Outdated
| } | ||
|
|
||
| const std::vector<std::string> FunctionInfo::GetOutputArgNames() const { | ||
| return schema_.GetOutputArgNames(); | ||
| void FunctionInfo::RemoveFeedFetch() { |
There was a problem hiding this comment.
RemoveFeedFetch 这个函数不适合放到 function_schema.cc 中，可以放到训练框架里
There was a problem hiding this comment.
将提到的几个函数移动到了utils文件内，感谢
paddle/fluid/jit/serializer.cc
Outdated
| @@ -62,6 +76,11 @@ bool Deserializer::IsPersistable(framework::VarDesc* desc_ptr) { | |||
| return desc_ptr->Persistable(); | |||
| } | |||
|
|
|||
| bool Deserializer::StartWith(const std::string& str, | |||
There was a problem hiding this comment.
StartWith, EndsWith, ReplaceAll，PdmodelFilePaths这一类应该是属于utils函数，不应该是某个类的成员函数
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
[JitLayer]Clean some include and polish load program code
dirname/file_prefix与jit.load保持一致