-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add federated learning parameter server(fl-ps) mode #42682
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
Sorry to inform you that 2873622's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
paddle/fluid/framework/data_feed.cc
Outdated
if (type[0] == 'f') { // float | ||
const auto& feasign = ins_vec[i].GetFloatData(); | ||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deleted
self._pull_all_dense(scopes, send_ctx, dense_map) | ||
fleet.util.barrier() | ||
fleet.util.barrier() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check this with guanqun?
@@ -90,7 +94,6 @@ def _build_programs(self): | |||
|
|||
class GeoPsProgramBuilder(PsProgramBuilder): # 仅 CPU 模式 | |||
def __init__(self, pass_ctx): | |||
logger.info("start building geo-ps program") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check with caibei ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
program=None, | ||
scope=None, | ||
is_infer=False, | ||
debug=False, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这块找xinxuan确认下
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@@ -308,5 +333,5 @@ Scope* HeterPipelineTrainer::GetWorkerScope(int thread_id) { | |||
} | |||
|
|||
} // end namespace framework | |||
} // end namespace paddle | |||
} // namespace paddle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不应该去掉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@@ -2365,7 +2359,7 @@ def _start_heter_trainer(self, | |||
fetch_info=fetch_info, | |||
print_period=print_period) | |||
|
|||
trainer._set_infer(is_infer) | |||
trainer._set_infer(False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hardcode?
if not self.context['use_ps_gpu']: | ||
self._pull_all_dense(scopes, send_ctx, dense_map) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if xx mode:
push dense param
barrier
pull dense
elif xx1 mode:
push dense param1
barrier
pull dense1
else ...
@@ -0,0 +1,49 @@ | |||
# Copyright (c) 2021 PaddlePaddle Authors. All Rights Reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyright (c) 2022
@@ -0,0 +1,53 @@ | |||
# Copyright (c) 2021 PaddlePaddle Authors. All Rights Reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyright (c) 2022
@@ -0,0 +1,51 @@ | |||
#!/bin/bash | |||
|
|||
# Copyright (c) 2020 PaddlePaddle Authors. All Rights Reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyright (c) 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* back fl * delete ssl cert * . * make warning * . * unittest paral degree * solve unittest * heter & multi cloud commm ready * . * . * fl-ps v1.0 * . * support N + N mode * . * . * . * . * delete print * . * . * . * .
PR types
New features
PR changes
Others
Describe