V2 API save and load param header #3619
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tensor-tang
reviewed
Aug 24, 2017
| @@ -34,7 +34,7 @@ def __init__(self, output_layer, parameters): | |||
| val = param.getBuf(api.PARAMETER_VALUE) | |||
| name = param.getName() | |||
| assert isinstance(val, api.Vector) | |||
| val.copyFromNumpyArray(parameters.get(name).flatten()) | |||
| val.copyFromNumpyArray(parameters.get(name)[1].flatten()) | |||
There was a problem hiding this comment.
这里为什么需要改动inference的code？那么Training的时候也需要改吗？
There was a problem hiding this comment.
因为原来：value = parameter.get(name)
现在：header, value = parameter.get(name)
Training的时候，改在parameters.py里面了
| @@ -43,7 +43,7 @@ def test_serialization(self): | |||
| params.__append_config__(__rand_param_config__("param_1")) | |||
|
|
|||
| for name in params.names(): | |||
| param = params.get(name) | |||
| param = params.get(name)[1] | |||
There was a problem hiding this comment.
这里只测试了[1]，有没有办法也测试[0]的值？代表的是header的值对吧
There was a problem hiding this comment.
[0]代表header的值。这里header默认都是0，所以都没做测试。可以等以后mkldnn的header进来，再另加一个单测。
|
在我本地机器上测试了下。 LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #3571
fix #3519
Test successfully on book/01.fit_a_line.